Patchwork [PULL,05/24] configure: Don't override ARCH=unknown if enabling TCI

login
register
mail settings
Submitter riku.voipio@linaro.org
Date June 24, 2016, 9:53 a.m.
Message ID <f28b11f56dc9c6b1f5f183ac02bb18065d5a3c8b.1466760944.git.riku.voipio@linaro.org>
Download mbox | patch
Permalink /patch/39689/
State New
Headers show

Comments

riku.voipio@linaro.org - June 24, 2016, 9:53 a.m.
From: Peter Maydell <peter.maydell@linaro.org>

At the moment if configure finds an unknown CPU it will set
ARCH to 'unknown', and then later either bail out or set it
to 'tci' (depending on whether the user passed configure the
--enable-tcg-interpreter switch). This is unnecessarily
confusing, because we could be using TCI in two cases:
 * a known host architecture (in which case ARCH is set to
   the actual host architecture, like 'i386')
 * an unknown host architecture (in which case ARCH is
   set to 'tci')
so nothing can rely on ARCH=tci to mean "using TCI".
Remove the line setting ARCH, so we leave it as "unknown",
which is what the actual situation is.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 configure | 1 -
 1 file changed, 1 deletion(-)

Patch

diff --git a/configure b/configure
index 5929aba..6696316 100755
--- a/configure
+++ b/configure
@@ -1380,7 +1380,6 @@  fi
 if test "$ARCH" = "unknown"; then
     if test "$tcg_interpreter" = "yes" ; then
         echo "Unsupported CPU = $cpu, will use TCG with TCI (experimental)"
-        ARCH=tci
     else
         error_exit "Unsupported CPU = $cpu, try --enable-tcg-interpreter"
     fi