Patchwork [OSSTEST] ts-xen-build-prep: Install libelf-dev for benefit of linux.git

login
register
mail settings
Submitter Ian Jackson
Date Nov. 15, 2017, 11:11 a.m.
Message ID <1510744260-27793-1-git-send-email-ian.jackson@eu.citrix.com>
Download mbox | patch
Permalink /patch/384497/
State New
Headers show

Comments

Ian Jackson - Nov. 15, 2017, 11:11 a.m.
Linux upstream has started needing libelf-dev.  Without it, recent tip
fails (in our configuration) like this:

 Makefile:938: *** "Cannot generate ORC metadata for CONFIG_UNWINDER_ORC=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel".  Stop.

It is not clear exactly when this requirement was introduced.  Our
bisector said:
  Bug introduced:  91a6a6cfee8ad34ea4cc10a54c0765edfe437cdb
  Bug not present: 1c9dbd4615fd751e5e0b99807a3c7c8612e28e20
but the "introduced" commit is a merge of a large branch, so it's not
blaming a specific commit.  None of the commits in that range mention
libelf so the most likely reason is a consequence of a change to some
configuration interactions (ie, probably, an expansion of the scope of
an existing dependency).

CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
CC: Juergen Gross <jgross@suse.com>
CC: Paul Durrant <paul.durrant@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 ts-xen-build-prep | 1 +
 1 file changed, 1 insertion(+)
Juergen Gross - Nov. 15, 2017, 11:40 a.m.
On 15/11/17 12:11, Ian Jackson wrote:
> Linux upstream has started needing libelf-dev.  Without it, recent tip
> fails (in our configuration) like this:
> 
>  Makefile:938: *** "Cannot generate ORC metadata for CONFIG_UNWINDER_ORC=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel".  Stop.

The kernel now is using objtool to create unwind information. This needs
libelf to work. Advantage is that this approach no longer depends on
assembler sources being heavily annotated with unwind hints.

> It is not clear exactly when this requirement was introduced.  Our
> bisector said:
>   Bug introduced:  91a6a6cfee8ad34ea4cc10a54c0765edfe437cdb
>   Bug not present: 1c9dbd4615fd751e5e0b99807a3c7c8612e28e20
> but the "introduced" commit is a merge of a large branch, so it's not
> blaming a specific commit.  None of the commits in that range mention
> libelf so the most likely reason is a consequence of a change to some
> configuration interactions (ie, probably, an expansion of the scope of
> an existing dependency).
> 
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> CC: Juergen Gross <jgross@suse.com>
> CC: Paul Durrant <paul.durrant@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Juergen Gross <jgross@suse.com>


Juergen
Ian Jackson - Nov. 15, 2017, 1:28 p.m.
Juergen Gross writes ("Re: [OSSTEST PATCH] ts-xen-build-prep: Install libelf-dev for benefit of linux.git"):
> The kernel now is using objtool to create unwind information. This needs
> libelf to work. Advantage is that this approach no longer depends on
> assembler sources being heavily annotated with unwind hints.

Thanks.  I have adopted that for the commit message.

> Acked-by: Juergen Gross <jgross@suse.com>

I will push this now to osstest pretest.

Ian.

Patch

diff --git a/ts-xen-build-prep b/ts-xen-build-prep
index 3e98364..3309216 100755
--- a/ts-xen-build-prep
+++ b/ts-xen-build-prep
@@ -207,6 +207,7 @@  sub prep () {
                       autoconf automake libtool xsltproc
                       libxml2-utils libxml2-dev
                       libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl
+                      libelf-dev
                       ccache nasm checkpolicy ebtables);
 
     if ($ho->{Suite} !~ m/squeeze|wheezy/) {