Patchwork KVM: MAINTAINERS improvements

login
register
mail settings
Submitter Andrew Jones
Date Aug. 10, 2017, 12:53 p.m.
Message ID <20170810125327.25315-1-drjones@redhat.com>
Download mbox | patch
Permalink /patch/313569/
State New
Headers show

Comments

Andrew Jones - Aug. 10, 2017, 12:53 p.m.
Remove nonexistent files, allow less awkward expressions when
extracting arch-specific information, and only return relevant
information when using arch-specific expressions. The arch-
specific expressions are now:

 /KVM/                                        -- All KVM
 /\(KVM\)|\(KVM\/x86\)/                       -- X86
 /\(KVM\)|\(KVM\/x86\)|\(KVM\/amd\)/          -- X86 plus AMD
 /\(KVM\)|\(KVM\/arm\)/                       -- ARM
 /\(KVM\)|\(KVM\/arm\)|\(KVM\/arm64\)/        -- ARM plus ARM64
 /\(KVM\)|\(KVM\/powerpc\)/                   -- POWERPC
 /\(KVM\)|\(KVM\/s390\)/                      -- S390
 /\(KVM\)|\(KVM\/mips\)/                      -- MIPS

Signed-off-by: Andrew Jones <drjones@redhat.com>
---
 MAINTAINERS | 31 ++++++++++++++++++++-----------
 1 file changed, 20 insertions(+), 11 deletions(-)
Paolo Bonzini - Aug. 10, 2017, 12:58 p.m.
On 10/08/2017 14:53, Andrew Jones wrote:
> Remove nonexistent files, allow less awkward expressions when
> extracting arch-specific information, and only return relevant
> information when using arch-specific expressions. The arch-
> specific expressions are now:
> 
>  /KVM/                                        -- All KVM
>  /\(KVM\)|\(KVM\/x86\)/                       -- X86
>  /\(KVM\)|\(KVM\/x86\)|\(KVM\/amd\)/          -- X86 plus AMD
>  /\(KVM\)|\(KVM\/arm\)/                       -- ARM
>  /\(KVM\)|\(KVM\/arm\)|\(KVM\/arm64\)/        -- ARM plus ARM64
>  /\(KVM\)|\(KVM\/powerpc\)/                   -- POWERPC
>  /\(KVM\)|\(KVM\/s390\)/                      -- S390
>  /\(KVM\)|\(KVM\/mips\)/                      -- MIPS
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>

Since you are at it, there's also arch/*/include/uapi/asm/kvm*.h that
you could add...  Otherwise, it's nice!

Paolo

> ---
>  MAINTAINERS | 31 ++++++++++++++++++++-----------
>  1 file changed, 20 insertions(+), 11 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 84d6a8277cbd..1e84c21bcb9f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7387,18 +7387,28 @@ L:	kvm@vger.kernel.org
>  W:	http://www.linux-kvm.org
>  T:	git git://git.kernel.org/pub/scm/virt/kvm/kvm.git
>  S:	Supported
> -F:	Documentation/*/kvm*.txt
>  F:	Documentation/virtual/kvm/
> -F:	arch/*/kvm/
> -F:	arch/x86/kernel/kvm.c
> -F:	arch/x86/kernel/kvmclock.c
> -F:	arch/*/include/asm/kvm*
> -F:	include/linux/kvm*
> +F:	include/uapi/asm-generic/kvm*
>  F:	include/uapi/linux/kvm*
> -F:	virt/kvm/
> +F:	include/asm-generic/kvm*
> +F:	include/linux/kvm*
> +F:	include/kvm/iodev.h
> +F:	virt/kvm/*
>  F:	tools/kvm/
>  
> -KERNEL VIRTUAL MACHINE (KVM) FOR AMD-V
> +KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86)
> +M:	Paolo Bonzini <pbonzini@redhat.com>
> +M:	Radim Krčmář <rkrcmar@redhat.com>
> +L:	kvm@vger.kernel.org
> +W:	http://www.linux-kvm.org
> +T:	git git://git.kernel.org/pub/scm/virt/kvm/kvm.git
> +S:	Supported
> +F:	arch/x86/kvm/
> +F:	arch/x86/include/asm/kvm*
> +F:	arch/x86/kernel/kvm.c
> +F:	arch/x86/kernel/kvmclock.c
> +
> +KERNEL VIRTUAL MACHINE FOR AMD-V (KVM/amd)
>  M:	Joerg Roedel <joro@8bytes.org>
>  L:	kvm@vger.kernel.org
>  W:	http://www.linux-kvm.org/
> @@ -7406,7 +7416,7 @@ S:	Maintained
>  F:	arch/x86/include/asm/svm.h
>  F:	arch/x86/kvm/svm.c
>  
> -KERNEL VIRTUAL MACHINE (KVM) FOR ARM
> +KERNEL VIRTUAL MACHINE FOR ARM (KVM/arm)
>  M:	Christoffer Dall <christoffer.dall@linaro.org>
>  M:	Marc Zyngier <marc.zyngier@arm.com>
>  L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> @@ -7420,7 +7430,7 @@ F:	arch/arm/kvm/
>  F:	virt/kvm/arm/
>  F:	include/kvm/arm_*
>  
> -KERNEL VIRTUAL MACHINE (KVM) FOR POWERPC
> +KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc)
>  M:	Alexander Graf <agraf@suse.com>
>  L:	kvm-ppc@vger.kernel.org
>  W:	http://www.linux-kvm.org/
> @@ -7454,7 +7464,6 @@ L:	linux-s390@vger.kernel.org
>  W:	http://www.ibm.com/developerworks/linux/linux390/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git
>  S:	Supported
> -F:	Documentation/s390/kvm.txt
>  F:	arch/s390/include/asm/kvm*
>  F:	arch/s390/kvm/
>  F:	arch/s390/mm/gmap.c
>
Cornelia Huck - Aug. 10, 2017, 1:09 p.m.
On Thu, 10 Aug 2017 14:53:27 +0200
Andrew Jones <drjones@redhat.com> wrote:

> Remove nonexistent files, allow less awkward expressions when
> extracting arch-specific information, and only return relevant
> information when using arch-specific expressions. The arch-
> specific expressions are now:
> 
>  /KVM/                                        -- All KVM
>  /\(KVM\)|\(KVM\/x86\)/                       -- X86
>  /\(KVM\)|\(KVM\/x86\)|\(KVM\/amd\)/          -- X86 plus AMD
>  /\(KVM\)|\(KVM\/arm\)/                       -- ARM
>  /\(KVM\)|\(KVM\/arm\)|\(KVM\/arm64\)/        -- ARM plus ARM64
>  /\(KVM\)|\(KVM\/powerpc\)/                   -- POWERPC
>  /\(KVM\)|\(KVM\/s390\)/                      -- S390
>  /\(KVM\)|\(KVM\/mips\)/                      -- MIPS
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  MAINTAINERS | 31 ++++++++++++++++++++-----------
>  1 file changed, 20 insertions(+), 11 deletions(-)
> 

> @@ -7454,7 +7464,6 @@ L:	linux-s390@vger.kernel.org
>  W:	http://www.ibm.com/developerworks/linux/linux390/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git
>  S:	Supported
> -F:	Documentation/s390/kvm.txt

Hey, this file has only been gone for two years! :)

>  F:	arch/s390/include/asm/kvm*
>  F:	arch/s390/kvm/
>  F:	arch/s390/mm/gmap.c

Acked-by: Cornelia Huck <cohuck@redhat.com>
Andrew Jones - Aug. 10, 2017, 1:13 p.m.
On Thu, Aug 10, 2017 at 02:58:03PM +0200, Paolo Bonzini wrote:
> On 10/08/2017 14:53, Andrew Jones wrote:
> > Remove nonexistent files, allow less awkward expressions when
> > extracting arch-specific information, and only return relevant
> > information when using arch-specific expressions. The arch-
> > specific expressions are now:
> > 
> >  /KVM/                                        -- All KVM
> >  /\(KVM\)|\(KVM\/x86\)/                       -- X86
> >  /\(KVM\)|\(KVM\/x86\)|\(KVM\/amd\)/          -- X86 plus AMD
> >  /\(KVM\)|\(KVM\/arm\)/                       -- ARM
> >  /\(KVM\)|\(KVM\/arm\)|\(KVM\/arm64\)/        -- ARM plus ARM64
> >  /\(KVM\)|\(KVM\/powerpc\)/                   -- POWERPC
> >  /\(KVM\)|\(KVM\/s390\)/                      -- S390
> >  /\(KVM\)|\(KVM\/mips\)/                      -- MIPS
> > 
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> 
> Since you are at it, there's also arch/*/include/uapi/asm/kvm*.h that
> you could add...  Otherwise, it's nice!

I'll send a v2. I found a couple other missing files as well

KVM (general)
 include/trace/events/kvm.h

POWERPC
 arch/powerpc/kernel/kvm*

drew

> 
> Paolo
> 
> > ---
> >  MAINTAINERS | 31 ++++++++++++++++++++-----------
> >  1 file changed, 20 insertions(+), 11 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 84d6a8277cbd..1e84c21bcb9f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -7387,18 +7387,28 @@ L:	kvm@vger.kernel.org
> >  W:	http://www.linux-kvm.org
> >  T:	git git://git.kernel.org/pub/scm/virt/kvm/kvm.git
> >  S:	Supported
> > -F:	Documentation/*/kvm*.txt
> >  F:	Documentation/virtual/kvm/
> > -F:	arch/*/kvm/
> > -F:	arch/x86/kernel/kvm.c
> > -F:	arch/x86/kernel/kvmclock.c
> > -F:	arch/*/include/asm/kvm*
> > -F:	include/linux/kvm*
> > +F:	include/uapi/asm-generic/kvm*
> >  F:	include/uapi/linux/kvm*
> > -F:	virt/kvm/
> > +F:	include/asm-generic/kvm*
> > +F:	include/linux/kvm*
> > +F:	include/kvm/iodev.h
> > +F:	virt/kvm/*
> >  F:	tools/kvm/
> >  
> > -KERNEL VIRTUAL MACHINE (KVM) FOR AMD-V
> > +KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86)
> > +M:	Paolo Bonzini <pbonzini@redhat.com>
> > +M:	Radim Krčmář <rkrcmar@redhat.com>
> > +L:	kvm@vger.kernel.org
> > +W:	http://www.linux-kvm.org
> > +T:	git git://git.kernel.org/pub/scm/virt/kvm/kvm.git
> > +S:	Supported
> > +F:	arch/x86/kvm/
> > +F:	arch/x86/include/asm/kvm*
> > +F:	arch/x86/kernel/kvm.c
> > +F:	arch/x86/kernel/kvmclock.c
> > +
> > +KERNEL VIRTUAL MACHINE FOR AMD-V (KVM/amd)
> >  M:	Joerg Roedel <joro@8bytes.org>
> >  L:	kvm@vger.kernel.org
> >  W:	http://www.linux-kvm.org/
> > @@ -7406,7 +7416,7 @@ S:	Maintained
> >  F:	arch/x86/include/asm/svm.h
> >  F:	arch/x86/kvm/svm.c
> >  
> > -KERNEL VIRTUAL MACHINE (KVM) FOR ARM
> > +KERNEL VIRTUAL MACHINE FOR ARM (KVM/arm)
> >  M:	Christoffer Dall <christoffer.dall@linaro.org>
> >  M:	Marc Zyngier <marc.zyngier@arm.com>
> >  L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> > @@ -7420,7 +7430,7 @@ F:	arch/arm/kvm/
> >  F:	virt/kvm/arm/
> >  F:	include/kvm/arm_*
> >  
> > -KERNEL VIRTUAL MACHINE (KVM) FOR POWERPC
> > +KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc)
> >  M:	Alexander Graf <agraf@suse.com>
> >  L:	kvm-ppc@vger.kernel.org
> >  W:	http://www.linux-kvm.org/
> > @@ -7454,7 +7464,6 @@ L:	linux-s390@vger.kernel.org
> >  W:	http://www.ibm.com/developerworks/linux/linux390/
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git
> >  S:	Supported
> > -F:	Documentation/s390/kvm.txt
> >  F:	arch/s390/include/asm/kvm*
> >  F:	arch/s390/kvm/
> >  F:	arch/s390/mm/gmap.c
> > 
>
Andrew Jones - Aug. 10, 2017, 1:19 p.m.
On Thu, Aug 10, 2017 at 02:53:27PM +0200, Andrew Jones wrote:
> Remove nonexistent files, allow less awkward expressions when
> extracting arch-specific information, and only return relevant
> information when using arch-specific expressions. The arch-
> specific expressions are now:
> 
>  /KVM/                                        -- All KVM
>  /\(KVM\)|\(KVM\/x86\)/                       -- X86
>  /\(KVM\)|\(KVM\/x86\)|\(KVM\/amd\)/          -- X86 plus AMD
>  /\(KVM\)|\(KVM\/arm\)/                       -- ARM
>  /\(KVM\)|\(KVM\/arm\)|\(KVM\/arm64\)/        -- ARM plus ARM64
>  /\(KVM\)|\(KVM\/powerpc\)/                   -- POWERPC
>  /\(KVM\)|\(KVM\/s390\)/                      -- S390
>  /\(KVM\)|\(KVM\/mips\)/                      -- MIPS

Hmm, maybe this should have been an RFC, as I have a request
for comment on whether or not we're concerned with breaking
current scripts that depend on the old format. Any script
using an expression like

 /\(KVM\) FOR POWERPC/

will now fail, as I've moved/modified "(KVM)".

Thanks,
drew

> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  MAINTAINERS | 31 ++++++++++++++++++++-----------
>  1 file changed, 20 insertions(+), 11 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 84d6a8277cbd..1e84c21bcb9f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7387,18 +7387,28 @@ L:	kvm@vger.kernel.org
>  W:	http://www.linux-kvm.org
>  T:	git git://git.kernel.org/pub/scm/virt/kvm/kvm.git
>  S:	Supported
> -F:	Documentation/*/kvm*.txt
>  F:	Documentation/virtual/kvm/
> -F:	arch/*/kvm/
> -F:	arch/x86/kernel/kvm.c
> -F:	arch/x86/kernel/kvmclock.c
> -F:	arch/*/include/asm/kvm*
> -F:	include/linux/kvm*
> +F:	include/uapi/asm-generic/kvm*
>  F:	include/uapi/linux/kvm*
> -F:	virt/kvm/
> +F:	include/asm-generic/kvm*
> +F:	include/linux/kvm*
> +F:	include/kvm/iodev.h
> +F:	virt/kvm/*
>  F:	tools/kvm/
>  
> -KERNEL VIRTUAL MACHINE (KVM) FOR AMD-V
> +KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86)
> +M:	Paolo Bonzini <pbonzini@redhat.com>
> +M:	Radim Krčmář <rkrcmar@redhat.com>
> +L:	kvm@vger.kernel.org
> +W:	http://www.linux-kvm.org
> +T:	git git://git.kernel.org/pub/scm/virt/kvm/kvm.git
> +S:	Supported
> +F:	arch/x86/kvm/
> +F:	arch/x86/include/asm/kvm*
> +F:	arch/x86/kernel/kvm.c
> +F:	arch/x86/kernel/kvmclock.c
> +
> +KERNEL VIRTUAL MACHINE FOR AMD-V (KVM/amd)
>  M:	Joerg Roedel <joro@8bytes.org>
>  L:	kvm@vger.kernel.org
>  W:	http://www.linux-kvm.org/
> @@ -7406,7 +7416,7 @@ S:	Maintained
>  F:	arch/x86/include/asm/svm.h
>  F:	arch/x86/kvm/svm.c
>  
> -KERNEL VIRTUAL MACHINE (KVM) FOR ARM
> +KERNEL VIRTUAL MACHINE FOR ARM (KVM/arm)
>  M:	Christoffer Dall <christoffer.dall@linaro.org>
>  M:	Marc Zyngier <marc.zyngier@arm.com>
>  L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> @@ -7420,7 +7430,7 @@ F:	arch/arm/kvm/
>  F:	virt/kvm/arm/
>  F:	include/kvm/arm_*
>  
> -KERNEL VIRTUAL MACHINE (KVM) FOR POWERPC
> +KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc)
>  M:	Alexander Graf <agraf@suse.com>
>  L:	kvm-ppc@vger.kernel.org
>  W:	http://www.linux-kvm.org/
> @@ -7454,7 +7464,6 @@ L:	linux-s390@vger.kernel.org
>  W:	http://www.ibm.com/developerworks/linux/linux390/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git
>  S:	Supported
> -F:	Documentation/s390/kvm.txt
>  F:	arch/s390/include/asm/kvm*
>  F:	arch/s390/kvm/
>  F:	arch/s390/mm/gmap.c
> -- 
> 2.13.4
>

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 84d6a8277cbd..1e84c21bcb9f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7387,18 +7387,28 @@  L:	kvm@vger.kernel.org
 W:	http://www.linux-kvm.org
 T:	git git://git.kernel.org/pub/scm/virt/kvm/kvm.git
 S:	Supported
-F:	Documentation/*/kvm*.txt
 F:	Documentation/virtual/kvm/
-F:	arch/*/kvm/
-F:	arch/x86/kernel/kvm.c
-F:	arch/x86/kernel/kvmclock.c
-F:	arch/*/include/asm/kvm*
-F:	include/linux/kvm*
+F:	include/uapi/asm-generic/kvm*
 F:	include/uapi/linux/kvm*
-F:	virt/kvm/
+F:	include/asm-generic/kvm*
+F:	include/linux/kvm*
+F:	include/kvm/iodev.h
+F:	virt/kvm/*
 F:	tools/kvm/
 
-KERNEL VIRTUAL MACHINE (KVM) FOR AMD-V
+KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86)
+M:	Paolo Bonzini <pbonzini@redhat.com>
+M:	Radim Krčmář <rkrcmar@redhat.com>
+L:	kvm@vger.kernel.org
+W:	http://www.linux-kvm.org
+T:	git git://git.kernel.org/pub/scm/virt/kvm/kvm.git
+S:	Supported
+F:	arch/x86/kvm/
+F:	arch/x86/include/asm/kvm*
+F:	arch/x86/kernel/kvm.c
+F:	arch/x86/kernel/kvmclock.c
+
+KERNEL VIRTUAL MACHINE FOR AMD-V (KVM/amd)
 M:	Joerg Roedel <joro@8bytes.org>
 L:	kvm@vger.kernel.org
 W:	http://www.linux-kvm.org/
@@ -7406,7 +7416,7 @@  S:	Maintained
 F:	arch/x86/include/asm/svm.h
 F:	arch/x86/kvm/svm.c
 
-KERNEL VIRTUAL MACHINE (KVM) FOR ARM
+KERNEL VIRTUAL MACHINE FOR ARM (KVM/arm)
 M:	Christoffer Dall <christoffer.dall@linaro.org>
 M:	Marc Zyngier <marc.zyngier@arm.com>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
@@ -7420,7 +7430,7 @@  F:	arch/arm/kvm/
 F:	virt/kvm/arm/
 F:	include/kvm/arm_*
 
-KERNEL VIRTUAL MACHINE (KVM) FOR POWERPC
+KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc)
 M:	Alexander Graf <agraf@suse.com>
 L:	kvm-ppc@vger.kernel.org
 W:	http://www.linux-kvm.org/
@@ -7454,7 +7464,6 @@  L:	linux-s390@vger.kernel.org
 W:	http://www.ibm.com/developerworks/linux/linux390/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git
 S:	Supported
-F:	Documentation/s390/kvm.txt
 F:	arch/s390/include/asm/kvm*
 F:	arch/s390/kvm/
 F:	arch/s390/mm/gmap.c